Commit 80b83f03 authored by Mark Heppner's avatar Mark Heppner

Remove TODOs

parent bfc04b1d
......@@ -252,11 +252,9 @@ class Cursor(object):
field_name, rep, mutate_to, cast_from = self._column_data_types[i]
# get the value from the field_name
# TODO handle None
value = getattr(column.scalar_value, field_name)
# cast the value
# TODO try/catch the casting
if cast_from is not None:
value = cast_from(value)
......
......@@ -143,7 +143,6 @@ JAVA_CLASSES = {
('java.sql.Timestamp', common_pb2.JAVA_SQL_TIMESTAMP, datetime_to_java_sql_timestamp, datetime_from_java_sql_timestamp),
],
'bytes_value': [
# TODO base64 encoding doesn't seem necessary with protobufs
('[B', common_pb2.BYTE_STRING, Binary, None),
],
'double_value': [
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment